refactor(kernel-browser-runtime): Migrate to JsonRpcEngineV2 #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
@SocketSecurity ignore npm/klona The "anomaly" is that a generalized deep clone in JavaScript may have side effects. |
sirtimid
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates all instances of
JsonRpcEnginetoJsonRpcEngineV2. This only affectskernel-browser-runtimeand should not change its behavior. The UI -> kernel JSON-RPC API can now handle JSON-RPC notifications (i.e. requests without an id), should we ever wish to add any.Note
Migrates kernel-browser-runtime to
@metamask/json-rpc-enginev2, updates middleware/tests, and enables handling JSON-RPC notifications in UI↔kernel messaging.JsonRpcEnginetoJsonRpcServer/JsonRpcEngineV2insrc/kernel-worker/kernel-worker.tsand middleware.logging: rewritten for v2JsonRpcMiddleware.panel-message: renamed tomakePanelMessageMiddleware, uses v2 API and returns results directly.ui-connections: handle JSON-RPC notifications (noid) by not sending replies; adjust handler type to returnJsonRpcResponse | void.@metamask/json-rpc-engineto^10.2.0; lockfile updated.@typescript-eslint/no-non-null-assertionin tests; update Vitest plugin link.vitest.config.ts.Written by Cursor Bugbot for commit b1961a4. This will update automatically on new commits. Configure here.